Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(combobox): fix form-associated test #8718

Merged
merged 1 commit into from
Feb 9, 2024
Merged

test(combobox): fix form-associated test #8718

merged 1 commit into from
Feb 9, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Feb 9, 2024

Related Issue: N/A

Summary

Fixes a test failure caused by conditional rendering of nodes.

Note: the grid key can be removed once we bump Stencil to v4.12.0 or greater as it introduced automatic key insertion.

@jcfranco jcfranco requested a review from a team as a code owner February 9, 2024 09:03
@jcfranco jcfranco requested a review from benelan February 9, 2024 09:04
@github-actions github-actions bot added the testing Issues related to automated or manual testing. label Feb 9, 2024
benelan
benelan approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@benelan benelan added the low risk Issues with low risk for consideration in low risk milestones label Feb 9, 2024
@jcfranco jcfranco added skip visual snapshots Pull requests that do not need visual regression testing. pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed skip visual snapshots Pull requests that do not need visual regression testing. labels Feb 9, 2024
@jcfranco jcfranco merged commit 820b166 into main Feb 9, 2024
19 of 20 checks passed
@jcfranco jcfranco deleted the jcfranco/stabilize-combobox-test branch February 9, 2024 19:26
Elijbet pushed a commit that referenced this pull request Feb 15, 2024
@jcfranco @Elijbet
test(combobox): fix form-associated test (#8718)
6b8a439 
**Related Issue:** N/A

## Summary

Fixes a test failure caused by conditional rendering of nodes. 

**Note**: the `grid` key can be removed once we bump Stencil to v4.12.0
or greater as it introduced [automatic `key`
insertion](https://github.com/ionic-team/stencil/releases/tag/v4.12.0).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan benelan approved these changes

Assignees

@jcfranco jcfranco

Labels
low risk Issues with low risk for consideration in low risk milestones pr ready for visual snapshots Adding this label will run visual snapshot testing. testing Issues related to automated or manual testing.
Projects
None yet
Milestone
2024-02-27 - Feb Maintenance Release
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @benelan